Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update valibot support #4415

Merged
merged 5 commits into from
Aug 23, 2023
Merged

feat: update valibot support #4415

merged 5 commits into from
Aug 23, 2023

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Aug 13, 2023

What

Valibot is undergoing some changes as noted in #4414 and this PR aims to adapt to that once it is released along with a few enhancements suggested by the author.

  • Support async schema types.
  • Support the new issues placement on the result object instead of the inner error object.

closes #4414

@logaretm logaretm marked this pull request as draft August 13, 2023 23:27
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023

Codecov Report

Merging #4415 (15edb8d) into main (10f301c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4415   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          79       79           
  Lines        6163     6163           
  Branches     1171     1171           
=======================================
  Hits         6050     6050           
  Misses        113      113           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@logaretm logaretm marked this pull request as ready for review August 23, 2023 00:17
@logaretm logaretm merged commit 03a4e99 into main Aug 23, 2023
8 checks passed
logaretm added a commit that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We will change the safeParseAsync API of Valibot
2 participants