Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(valibot): upgrade and migrate to v0.31.0 #4770

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

fabian-hiller
Copy link
Contributor

🔎 Overview

I have updated and migrated the Valibot adapter for our upcoming release.

Our migration guide: https://valibot.dev/guides/migrate-to-v0.31.0/

I did not update the docs because I was not sure how to handle this line. If you give me a hint, I will do it.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (b251ad0) to head (a19ca5e).

Current head a19ca5e differs from pull request most recent head ea5b3ea

Please upload reports for the commit ea5b3ea to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4770      +/-   ##
==========================================
+ Coverage   89.71%   89.75%   +0.03%     
==========================================
  Files          93       93              
  Lines        7845     7875      +30     
  Branches     1374     1374              
==========================================
+ Hits         7038     7068      +30     
  Misses        800      800              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabian-hiller
Copy link
Contributor Author

Please don't merge. I want to improve something first.

@logaretm
Copy link
Owner

logaretm commented Jun 4, 2024

@fabian-hiller Wow I was planning to do it myself after you tag your releases. Many thanks and I will await your go ahead!

I did not update the docs because I was not sure how to handle this line. If you give me a hint, I will do it.

Don't worry about that, it will get bumped with the next release.

@logaretm logaretm linked an issue Jun 4, 2024 that may be closed by this pull request
@fabian-hiller
Copy link
Contributor Author

Don't worry about that, it will get bumped with the next release.

Does this mean that I can upgrade Valibot in the docs to v0.31.0 without changing the line?

@fabian-hiller
Copy link
Contributor Author

Once the docs are updated to use wildcard imports and our new pipe API, this PR is ready. Wildcard imports are now the official recommended way to use Valibot because of the better DX (three shaking still works).

@logaretm
Copy link
Owner

logaretm commented Jun 4, 2024

I updated the docs to use the v.pipe with the import * as v from 'valibot' as the recommended. Also updated the live samples to have that.

Should I merge and tag a release then?

@fabian-hiller
Copy link
Contributor Author

I recommend waiting until tomorrow. I plan to release v0.31.0 today or tomorrow.

@fabian-hiller
Copy link
Contributor Author

v0.31.0 is available: https://valibot.dev/blog/valibot-v0.31.0-is-finally-available/

@logaretm logaretm merged commit ddc2151 into logaretm:main Jun 6, 2024
4 of 5 checks passed
@logaretm
Copy link
Owner

logaretm commented Jun 6, 2024

Released in v4.13.1, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vee-validate/valibot not yet compatible with Valibot 0.31.0
2 participants