Skip to content

Commit

Permalink
Minor nav abstraction
Browse files Browse the repository at this point in the history
  • Loading branch information
logashoff committed May 11, 2024
1 parent 12f56ca commit 6576199
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions src/app/components/new-tab/new-tab.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
class="search-form"
appSticky
[ngClass]="{ 'search-margin': hideTopSites$ | async }"
(activated)="navigate(['new-tab', 'search'])"
(canceled)="navigate(['new-tab', 'main'])"
(activated)="navigate('search')"
(canceled)="navigate('main')"
/>
<section class="content">
<router-outlet />
Expand Down
8 changes: 4 additions & 4 deletions src/app/components/new-tab/new-tab.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export class NewTabComponent implements OnInit {
hideTopSites$: Observable<boolean>;

constructor(
private homeService: HomeService,
private navService: NavService
private readonly homeService: HomeService,
private readonly navService: NavService
) {}

ngOnInit() {
Expand All @@ -54,8 +54,8 @@ export class NewTabComponent implements OnInit {
);
}

async navigate(commands) {
await this.navService.navigate(commands);
async navigate(...command: string[]) {
await this.navService.navigate(['/new-tab', ...command]);
scrollTop();
}
}
4 changes: 2 additions & 2 deletions src/app/components/popup/popup.component.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<app-search-form class="search-form"
appSticky
(activated)="navigate(['popup', 'search'])"
(canceled)="navigate(['popup', 'main'])" />
(activated)="navigate('search')"
(canceled)="navigate('main')" />
<div class="content">
<router-outlet />
</div>
6 changes: 3 additions & 3 deletions src/app/components/popup/popup.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ import { SearchFormComponent } from '../search-form/search-form.component';
imports: [RouterOutlet, SearchFormComponent, StickyDirective],
})
export class PopupComponent {
constructor(private navService: NavService) {}
constructor(private readonly navService: NavService) {}

async navigate(commands) {
await this.navService.navigate(commands);
async navigate(...commands: string[]) {
await this.navService.navigate(['/popup', ...commands]);
scrollTop();
}
}

0 comments on commit 6576199

Please sign in to comment.