Skip to content

Commit

Permalink
chore(deps): eslint-plugin-sensible@3.1.0
Browse files Browse the repository at this point in the history
adds support for node namespaced module requires
  • Loading branch information
esatterwhite committed Dec 12, 2023
1 parent 1dc3209 commit 533b039
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
14 changes: 11 additions & 3 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ def CURRENT_BRANCH = [env.CHANGE_BRANCH, env.BRANCH_NAME]?.find{branch -> branch
def DEFAULT_BRANCH = 'main'

pipeline {
agent none
agent {
node {
label 'ec2-fleet'
customWorkspace("/tmp/workspace/${env.BUILD_TAG}")
}
}

options {
timestamps()
Expand Down Expand Up @@ -36,12 +41,13 @@ pipeline {
axes {
axis {
name 'NODE_VERSION'
values '12', '14', '16'
values '16', '18', '20'
}
}

agent {
docker {
label 'ec2-fleet'
image "us.gcr.io/logdna-k8s/node:${NODE_VERSION}-ci"
}
}
Expand Down Expand Up @@ -91,7 +97,8 @@ pipeline {

agent {
docker {
image "us.gcr.io/logdna-k8s/node:12-ci"
image "us.gcr.io/logdna-k8s/node:14-ci"
label 'ec2-fleet'
customWorkspace "${PROJECT_NAME}-${BUILD_NUMBER}"
}
}
Expand Down Expand Up @@ -123,6 +130,7 @@ pipeline {
agent {
docker {
image "us.gcr.io/logdna-k8s/node:12-ci"
label 'ec2-fleet'
customWorkspace "${PROJECT_NAME}-${BUILD_NUMBER}"
}
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@
"dependencies": {
"eslint-plugin-logdna": "^2.0.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-sensible": "^3.0.3"
"eslint-plugin-sensible": "^3.1.0"
}
}
2 changes: 1 addition & 1 deletion test/fixtures/valid-code
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

// This is a very very long comment that should probably be on multiple line. But comments are ignored so this will not cause an error when the linter actually runs
const path = require('path')
const path = require('node:path')
const fs = require('fs')
const {promisify} = require('util')
const crypto = require('crypto')
Expand Down

0 comments on commit 533b039

Please sign in to comment.