Skip to content

Commit

Permalink
chore(deps): eslint-plugin-sensible@3.0.2
Browse files Browse the repository at this point in the history
includes a fix for the obsurd indent suggestions under certain
circumstances and potential range errors
  • Loading branch information
esatterwhite committed Mar 8, 2023
1 parent 5fad00b commit b9865bd
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"SharedArrayBuffer": "readonly"
},
"parserOptions": {
"ecmaVersion": 2020,
"ecmaVersion": 2022,
"sourceType": "script",
"ecmaFeatures": {
"globalReturn": true
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@
"dependencies": {
"eslint-plugin-logdna": "^2.0.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-sensible": "^3.0.1"
"eslint-plugin-sensible": "^3.0.2"
}
}
11 changes: 8 additions & 3 deletions test/failures.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,7 @@ test('Invalid linting for larger code blocks read from fixtures', async (t) => {
t.test('function-call-argument-newline', async (t) => {
const [result] = await linter.lintFiles(['function-call-argument-newline-fixture'])
const messages = result.messages
t.equal(result.errorCount, 3, 'error count')

t.equal(result.errorCount, 4, 'error count')
t.equal(
messages[0].message
, 'Expected newline after \'(\'.'
Expand All @@ -154,12 +153,18 @@ test('Invalid linting for larger code blocks read from fixtures', async (t) => {

t.equal(
messages[1].message
, 'Expected indentation of 14 spaces but found 0.'
, 'fooBar call 1: arguments should align on first punctuation'
)

t.equal(
messages[2].message
, 'Expected newline between arguments/params.'
, 'fooBar call 2: second param should be followed by newline'
)

t.equal(
messages[2].message
messages[3].message
, 'There should be a line break after this argument.'
, 'fooBar call 2: space after second param should be newline'
)
Expand Down

0 comments on commit b9865bd

Please sign in to comment.