Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Remote Restart and Redirecting Log Ingestion to New Endpoint #119

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Support for Remote Restart and Redirecting Log Ingestion to New Endpoint #119

merged 3 commits into from
Jul 29, 2019

Conversation

smusali
Copy link
Contributor

@smusali smusali commented Jul 29, 2019

No description provided.

@smusali smusali self-assigned this Jul 29, 2019
dchai76
dchai76 approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@dchai76 dchai76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but lgtm. If I really wanted to nitpick I'd recommend the title be "Support remote restart, redirecting log ingestion to new endpoint"

lib/connection-manager.js Show resolved Hide resolved
@smusali smusali changed the title Support for Redirecting Logs to New Endpoint/Host Support for Remote Restart and Redirecting Log Ingestion to New Endpoint Jul 29, 2019
@smusali smusali merged commit 90f69cc into master Jul 29, 2019
@smusali smusali deleted the endRedir branch July 29, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchai76 dchai76 dchai76 approved these changes

@respectus respectus Awaiting requested review from respectus

Assignees

@smusali smusali

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smusali @dchai76