Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update failure condition and debug statements #139

Merged
merged 3 commits into from
Nov 7, 2019
Merged

update failure condition and debug statements #139

merged 3 commits into from
Nov 7, 2019

Conversation

smusali
Copy link
Contributor

@smusali smusali commented Nov 7, 2019

all 2xx response status codes indicate success and recently 207 status code was introduced regarding batches.

updated debug and log statements as well to include status code.

@smusali smusali added the bugfix label Nov 7, 2019
@smusali smusali self-assigned this Nov 7, 2019
lib/linebuffer.js Outdated Show resolved Hide resolved
lib/linebuffer.js Outdated Show resolved Hide resolved
@smusali smusali requested a review from weizou19 November 7, 2019 16:25
lib/linebuffer.js Outdated Show resolved Hide resolved
@smusali smusali requested a review from weizou19 November 7, 2019 16:31
@smusali smusali merged commit 5e5faf1 into master Nov 7, 2019
@smusali smusali deleted the handle_2xx branch November 7, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants