fix: Revert environment variable changes #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we attempted to move to a single URL for the logger client and remove the many env vars that previously "built" the URL. However, doing a `major` release for this wasn't sufficient enough to not break customers, so we are putting them back until such time we can ensure a safer upgrade path for such breaking changes. Semver: patch Fixes: #206 Ref: LOG-7618
This fixes a bug in the Windows version when applications have the file open and obtain a lock. The solution is simply to wait until the process has released the lock and read again. Fixes: #167 Semver: patch
darinspivey
changed the title
mdeltito
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we attempted to move to a single URL
for the logger client and remove the many env vars
that previously "built" the URL. However, doing a
majorrelease for this wasn't sufficient enough to not break
customers, so we are putting them back until such time
we can ensure a safer upgrade path for such breaking
changes.
Semver: patch
Fixes: #206
Ref: LOG-7618
feat: Retry reading when file is locked
This fixes a bug in the Windows version when applications have the
file open and obtain a lock. The solution is simply to wait until
the process has released the lock and read again.
Fixes: #167
Semver: patch