Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Duplicate] Use systemd service name as the app name #210

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

smusali
Copy link
Contributor

@smusali smusali commented Oct 28, 2020

Considering the lack of activity on #169 and the need for rebasing, we needed to have a separate Pull Request for resolving #168

@smusali smusali added duplicate enhancement linux For LogDNA Linux Agent labels Oct 28, 2020
@smusali smusali self-assigned this Oct 28, 2020
Copy link
Contributor

@darinspivey darinspivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but can you make your commit body 72 characters or less, please?

Considering the lack of activity on #169 and the need for rebasing, we needed to have this for resolving #168
@manigandham
Copy link

manigandham commented Nov 26, 2020

This change has made all log entries by the logdna-agent use fluentbit.log on our GKE kubernetes cluster. Our exclusion rules for logdna-agent as the app name no longer work.

Is this intended? Is there a way to set the agent name explicitly?

image

@darinspivey
Copy link
Contributor

Hi @manigandham . What was the value of that field prior to the latest change? I suppose this is expected behavior since the value of that field can be a variety of values. The field is meant to be the filename of the file that contains the log message, so it seems correct. What's the reason this is problematic for you?

In a future change, we will have to allow this field to be specifically set by the user, but it will have to be added as a feature. We realize that until the above line is broken up into separate values configurable by the user, we will not be able to make all users happy (it's fixed for some users, but for others like yourself, it "broke" the expected value).

@manigandham
Copy link

It was previously set to logdna-agent and now reads fluentbit.log

This is the App field so should it be the filename instead of what's producing the logs? Especially since there's already a File label. I don't have enough retention to show an example of a log line from before but this is a current log entry:

image

Or is this a parsing issue for the logs? Let me know if I'm off base here.

@darinspivey
Copy link
Contributor

Can you confirm for me what version you're using? I see that the log levels are lower-cased (debug), but the most recent version uses upper-cased levels for consistency.

@manigandham
Copy link

manigandham commented Dec 2, 2020

image is: logdna/logdna-agent-v2:stable

last pulled on 11/25

From https://assets.logdna.com/clients/agent-resources.yaml

@darinspivey
Copy link
Contributor

Ah, ok, that tells us everything. We're really sorry for the confusion, but the version you're running is actually our Rust version, not the code on this PR. We're working on renaming the two versions appropriately, but it's a long process to change legacy names, so thanks for bearing with us.

We need to move this topic off of this old PR and get you onto a new issue. Would you mind opening an official issue under the "v2" repo describing what you're expecting to see? The screen shots really helped too. The correct repo is this: https://github.com/logdna/logdna-agent-v2/issues

Thanks!

@manigandham
Copy link

Ok done, thanks. logdna/logdna-agent-v2#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate enhancement linux For LogDNA Linux Agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants