Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding LOGDNA_LOGENDPOINT #68

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Adding LOGDNA_LOGENDPOINT #68

merged 2 commits into from
Dec 17, 2018

Conversation

smusali
Copy link
Contributor

@smusali smusali commented Dec 17, 2018

Adding new LOGDNA_LOGENDPOINT environment variable which has /logs/agent as a default value.

@smusali smusali self-assigned this Dec 17, 2018
@smusali smusali requested a review from leeliu December 17, 2018 21:32
@smusali
Copy link
Contributor Author

smusali commented Dec 17, 2018

so, @leeliu , basically, 2 questions:

  1. is the name LOGDNA_LOGENDPOINT okay? I was thinking of using LOGDNA_LOGPATH but it’s not that much descriptive;
  2. do you wanna customize API Client Authentication Endpoint too?

@leeliu leeliu merged commit d0584a1 into logdna:master Dec 17, 2018
@smusali smusali deleted the endpointEnv branch December 17, 2018 22:45
@CJP10 CJP10 restored the endpointEnv branch March 26, 2019 20:41
@CJP10 CJP10 deleted the endpointEnv branch March 26, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeliu leeliu Awaiting requested review from leeliu

Assignees

@smusali smusali

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smusali @leeliu