Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Having Space in WinEvents #91

Merged
merged 5 commits into from
Apr 30, 2019
Merged

Support for Having Space in WinEvents #91

merged 5 commits into from
Apr 30, 2019

Conversation

smusali
Copy link
Contributor

@smusali smusali commented Apr 15, 2019

With this, now agent (v1) supports -w System,Security,Setup,Domain+Controller,"Windows+DNS", where it takes care of the case by:

  • discarding final empty argument;
  • replaces + (makes it flexible for customers) with (whitespace);
  • trimming by removing quotes as well; so,
> sudo logdna-agent -w System,Security,Setup,Domain+Controller,"Windows+DNS",
Windows Events: System, Security, Setup, Domain Controller, and Windows DNS have been saved to config.

Notes:

  • Added extra flag to utils.split in order not to mess up with glob patterns which can be used for directories and files;
  • Beautified post-config-change messages.

@smusali smusali self-assigned this Apr 15, 2019
@smusali smusali requested a review from RYadav95 April 15, 2019 21:24
@smusali smusali requested review from dchai76 and removed request for gregswift and RYadav95 April 24, 2019 17:57
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Show resolved Hide resolved
@smusali smusali merged commit b40919c into logdna:master Apr 30, 2019
@smusali smusali deleted the winEventSpaceSupport branch April 30, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants