refactor!: batch logs and periodically flush buffer #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeltito
commented
Sep 1, 2020
mdeltito
force-pushed
the
mdeltito/LOG-6965
branch
from
6c7a2fc
to
ba75fef
Compare
mdeltito
force-pushed
the
mdeltito/LOG-6965
branch
from
ba75fef
to
05c45b4
Compare
dm36
previously approved these changes
Sep 2, 2020
BREAKING CHANGE: * rename CreateLogger to NewLogger to better align with best practice * break out transport code and reimplement FlushInterval * logs are now flushed periodically - new default is 250ms * logs are also async flushed when hitting the MaxBufferLen * maxBufferLen default increased to 50 * logs are now batched when sending, up to MaxBufferLen * add a configurable SendTimeout, default of 5 seconds Semver: major Ref: LOG-6965
mdeltito
force-pushed
the
mdeltito/LOG-6965
branch
from
05c45b4
to
a36f1c9
Compare
dm36
approved these changes
Sep 2, 2020
smusali
reviewed
Sep 3, 2020
smusali
reviewed
Sep 3, 2020
smusali
approved these changes
Sep 8, 2020
zeldanut
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Semver: major
Ref: LOG-6965