-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: Prepare package for 2.0.0 release #12
Conversation
29b681a
to
c700f5f
Compare
9e46e17
to
13dd8ae
Compare
21e5dfa
to
ef59657
Compare
@@ -39,7 +39,7 @@ jobs: | |||
- checkout | |||
- run: | |||
name: ZIP the Codebase | |||
command: zip logdna-go.zip -r logger/logdna.go go.mod | |||
command: zip logdna-go.zip -r logger.go logger_test.go options.go options_test.go go.mod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross compiling Go is rather trivial these days. Rather that releasing a zip of source, why not provide pre-built binaries?
Or better, provide both. Source zip and prebuilt binaries for win, macos + linux. You don't even need the native OS to do it in most cases
# build for macos on linux
GOOS=darwin GOARCH=amd64 go build logger.go
# build for windows on linux
GOOS=windows and GOARCH=386 go build logger.go
Thats a pretty simple first step before with out needing to figure out OS package managers.
Should probably also provide a tar.gz
file which is more common place on *nix systems.
Make it easy for people. Most users would rather not have to compile things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a library, it's not useful for this to be compiled on its own - a standalone binary would not do anything.
@dm36 what is the reason for generating a zip file as a release on github here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdeltito i think that was a change implemented by @smusali so will delegate to him to answer that question- but yup looks like the circleci config zips and packages it for release- it looks like we do this for the logger-node project as well: https://github.com/logdna/logger-node/blob/master/.circleci/config.yml
ef59657
to
887661b
Compare
Adds examples files, updates the README and removes the logger subdirectory. Semver: Patch Ref: LOG-7109
improvement: Prepares package for 2.0.0 release
Adds examples files, updates the README and removes the logger subdirectory.
Semver: Patch
Ref: LOG-7109