Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add proxy support #11

Merged
merged 1 commit into from
Sep 8, 2020
Merged

feat: Add proxy support #11

merged 1 commit into from
Sep 8, 2020

Conversation

darinspivey
Copy link
Collaborator

Certain implementations may require traffic to pass through a proxy
before reaching the outside world (and the LogDNA server). This
uses the https-proxy-agent package to add proxy capability
to the HTTP agent.

Semver: minor
Ref: LOG-7175

@darinspivey darinspivey added the enhancement New feature or request label Sep 3, 2020
README.md Outdated Show resolved Hide resolved
lib/logger.js Show resolved Hide resolved
mdeltito
mdeltito previously approved these changes Sep 3, 2020
test/logger-log.js Outdated Show resolved Hide resolved
mdeltito
mdeltito previously approved these changes Sep 8, 2020
README.md Outdated Show resolved Hide resolved
Copy link

@smusali smusali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small request

README.md Outdated Show resolved Hide resolved
Certain implementations may require traffic to pass through a proxy
before reaching the outside world (and the LogDNA server).  This
uses the `https-proxy-agent` package to add proxy capability
to the HTTP agent.

Semver: minor
Ref: LOG-7175
Copy link
Member

@mdeltito mdeltito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest with proxy renaming LGTM

Copy link

@smusali smusali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@darinspivey darinspivey merged commit 3bf0ecf into master Sep 8, 2020
@darinspivey darinspivey deleted the darinspivey/LOG-7175 branch September 8, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants