improvement: Add more error retry codes, and handle 207 partial-success responses #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinspivey
changed the title
mdeltito
reviewed
Sep 1, 2020
mdeltito
previously approved these changes
Sep 1, 2020
darinspivey
commented
Sep 2, 2020
This change enhances our list of error codes for status as well as connection-based error codes. This will allow the client to be more intelligent about when to retry. Semver: minor Ref: LOG-7151
darinspivey
force-pushed
the
darinspivey/LOG-7151
branch
2 times, most recently
from
dac996d
to
cb2a1e0
Compare
If we get a partial-success (207) response, emit errors for the failed lines. This maintains feature parity with the agent in preparation for using this client inside of the agent. Semver: minor Ref: LOG-7151
darinspivey
force-pushed
the
darinspivey/LOG-7151
branch
from
cb2a1e0
to
097afbb
Compare
mdeltito
approved these changes
Sep 2, 2020
smusali
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvement: Handle partial-success 207 responses
If we get a partial-success (207) response, emit errors for
the failed lines. This maintains feature parity with the agent
in preparation for using this client inside of the agent.
Semver: minor
Ref: LOG-7151
improvement: Add more error codes for retry
This change enhances our list of error codes for status as well as
connection-based error codes. This will allow the client to be more
intelligent about when to retry.
Semver: minor
Ref: LOG-7151