Allow log methods to receive block #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 8, 2018 11:33
As the Ruby logger does, logging methods should be able to receive a block with the message, that allows to delay the evaluation of complex messages until the message is actually logged.
|
Hi @respectus! What do you think about this PR? |
|
Hi @ndrisso, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Ruby logger does, logging methods should be able to receive a block with the message, that allows to delay the evaluation of complex messages until the message is actually logged.
Also by doing this, this gem will be out of the box compatible with Rails, in the sense that it will work with the Rack middleware responsable of logging every request https://github.com/rails/rails/blob/ee35b79d4cff24b960be54c3f5c4f46627c069fe/railties/lib/rails/rack/logger.rb#L37