feat(alerts): add preset alert logdna_alert as a data source
#31
Conversation
david-ly
added
documentation
david-ly
force-pushed
the
david-ly/LOG-10590
branch
from
05cb20e
to
c08e5bd
Compare
david-ly
force-pushed
the
david-ly/LOG-10590
branch
from
c08e5bd
to
99867a3
Compare
david-ly
force-pushed
the
david-ly/LOG-10590
branch
5 times, most recently
from
d1fb1d9
to
665765c
Compare
logdna/resource_view_test.go
Outdated
| category1 := "DEMOCATEGORY1" | ||
| category2 := "DemoCategory2" | ||
| category1 := "category1" | ||
| category2 := "category2" |
There was a problem hiding this comment.
changing these will require changes on the integration account in production - is there a reason for switching these?
also iirc these were set up with mixed casing specifically for testing that scenario
There was a problem hiding this comment.
@mdeltito nah this was just a byproduct of troubleshooting the tests, I was using the service key for the LogDNA Canary account in production instead of the MDT-terraform account which is why the Jenkins builds weren't passing. This took me an unfortunate amount of time to figure out since the local testing didn't 100% align with the build results.
Reverted my changes since the tests were already correct initially.
There was a problem hiding this comment.
instead of the MDT-terraform account
@david-ly the CI account is named:
Terraform Plugin Provider Tests (terraform-provider-logdna)
we should get that into the docs and make sure it's available to everyone (edit: done, opened it up)
There was a problem hiding this comment.
Access control is wide open, I've confirmed. Looks like just a doc issue now.
Allow members with an @logdna.com email to join this organization without a request.
There was a problem hiding this comment.
Gotcha, thanks for clarifying. I'll add this to the docs in a future PR
david-ly
force-pushed
the
david-ly/LOG-10590
branch
4 times, most recently
from
053c1b5
to
ed0cf7a
Compare
Creates a `logdna_alert` data source which provides support for remotely fetching information from existing preset alerts. Added tests, updated the documentation, and included it in the provider. Semver: minor Ref: LOG-10590
david-ly
force-pushed
the
david-ly/LOG-10590
branch
from
ed0cf7a
to
7cfd622
Compare
david-ly
dismissed
tanberry’s stale review
Outdated and currently blocking merge
Creates a
logdna_alertdata source which provides support forremotely fetching information from existing preset alerts. Added
tests, updated the documentation, and included it in the provider.
Semver: minor
Ref: LOG-10590