Deprecate AsynDisruptorAppender#setProducerType()

closes #608
logfellow · Aug 24, 2021 · 1c403cc · 1c403cc
1 parent 432a427
commit 1c403cc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -790,7 +790,7 @@ e.g.<br/><tt>phasedBackoff{10,60,seconds,blocking}</tt></td>
 </table>
 
 See [AsyncDisruptorAppender](/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java)
-for other configuration parameters (such as `ringBufferSize`, `producerType`, `threadNamePrefix`, `daemon`, and `droppedWarnFrequency`)
+for other configuration parameters (such as `ringBufferSize`, `threadNamePrefix`, `daemon`, and `droppedWarnFrequency`)
 
 
 ### Appender Listeners

diff --git a/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java b/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java
@@ -644,8 +644,17 @@ public void setRingBufferSize(int ringBufferSize) {
     public ProducerType getProducerType() {
         return producerType;
     }
+
+    /**
+     * Set the {@link ProducerType} to use to configure the disruptor.
+     * 
+     * @deprecated ProducerType will be fixed to MULTI in future release and this method removed without any replacement.
+     * @param producerType the type of producer
+     */
+    @Deprecated
     public void setProducerType(ProducerType producerType) {
-        this.producerType = producerType;
+        this.producerType = Objects.requireNonNull(producerType);
+        addWarn("setProducerType() is deprecated and will be removed without replacement in future release");
     }
 
     public WaitStrategy getWaitStrategy() {