Switch from FastDateFormat for higher precision timestamps #364
Comments
|
Sorry, I don't know how to like PR's to Issues, but take a look at #365 |
|
Nice, though I don't have enough Java experience or knowledge of the code to be able to really review it. Though I guess LOGBACK-1374 would be necessary as well, since I hadn't noticed that the timestamp is gotten from |
|
Thanks for the issue report @kyrias and PR @J-Jimmy ! I 100% agree with replacing As you mentioned @kyrias , higher-precision timestamps won't be supported until logback supports them, but we can go ahead and make the necessary changes in logstash-logback-encoder in preparation. I've added some review comments on the PR that need to be addressed before I can merge the PR. Also, this change will require a major version bump of logstash-logback-encoder. So I might hold off on it for a bit. There's no real immediate need for it since logback doesn't support higher-precision timestamps yet. |
Remove dependency on apache commons-lang3 (since FastDateFormat was the only thing being used). Switch default timestamp format to DateTimeFormatter.ISO_OFFSET_DATE_TIME Added the ability to specify DateTimeFormatter constant names as patterns. This change is NOT fully backwards compatible, since: * the default timestamp pattern changed to DateTimeFormatter.ISO_OFFSET_DATE_TIME * the pattern strings supported by DateTimeFormatter are not exactly the same as those supported by FastDateFormat
|
Closing this in favor of #377 |
Currently
logstash-logback-encoderusesFastDateFormatto generate the timestamps, but it is limited to millisecond precision. Java 8 addedjava.timewhich has nanosecond precision. Sincelogstash-logback-encoder >= 6requires Java 8, would it be possible to switch tojava.time.Instantfor generating the timestamps instead?The text was updated successfully, but these errors were encountered: