Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support keyValue pairs provided by slf4j 2.x fluent api #946

Closed
philsttr opened this issue Apr 5, 2023 · 0 comments · Fixed by #954
Closed

Support keyValue pairs provided by slf4j 2.x fluent api #946

philsttr opened this issue Apr 5, 2023 · 0 comments · Fixed by #954
Labels
type/enhancement

Comments

@philsttr
Copy link
Collaborator

philsttr commented Apr 5, 2023

slf4j 2.x added a new fluent api that allows adding key value pairs to log events. For example:

logger.atDebug().setMessage("Temperature changed.").addKeyValue("oldT", oldT).addKeyValue("newT", newT).log();

Support outputting these key value pairs in the encoders provided by logstash-logback-encoder. Exactly how is TBD.
@philsttr philsttr changed the title Support keyValue pairs logged via slf4j 2.x fluent api Support keyValue pairs provided by slf4j 2.x fluent api Apr 5, 2023
@mmienko mmienko mentioned this issue May 15, 2023
Merged
@philsttr philsttr linked a pull request Jun 17, 2023 that will close this issue
Support key values from slf4j's fluent api #954
Merged
philsttr added a commit that referenced this issue Jun 17, 2023
@philsttr
Merge pull request #954 from mmienko/support-key-value-fluent-api
16c92fc 
Support key values from slf4j's fluent api

Fixes #946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support key values from slf4j's fluent api mmienko/logstash-logback-encoder
1 participant
@philsttr