-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support key values from slf4j's fluent api #954
Merged
philsttr
merged 9 commits into
logfellow:main
from
mmienko:support-key-value-fluent-api
Jun 17, 2023
Merged
Support key values from slf4j's fluent api #954
philsttr
merged 9 commits into
logfellow:main
from
mmienko:support-key-value-fluent-api
Jun 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmienko
commented
May 15, 2023
src/main/java/net/logstash/logback/composite/loggingevent/KeyValuePairJsonProvider.java
Outdated
Show resolved
Hide resolved
osigida
reviewed
May 16, 2023
osigida
reviewed
May 16, 2023
src/main/java/net/logstash/logback/composite/loggingevent/KeyValuePairJsonProvider.java
Outdated
Show resolved
Hide resolved
ferhtaydn
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@osigida can you merge if there's nothing left to address?
Codecov Report
@@ Coverage Diff @@
## main #954 +/- ##
============================================
- Coverage 72.05% 71.66% -0.40%
- Complexity 1353 1386 +33
============================================
Files 173 174 +1
Lines 4999 5113 +114
Branches 517 528 +11
============================================
+ Hits 3602 3664 +62
- Misses 1148 1189 +41
- Partials 249 260 +11
|
philsttr
force-pushed
the
support-key-value-fluent-api
branch
from
June 17, 2023 15:11
5b51802
to
07314e5
Compare
philsttr
changed the title
Support key value fluent api
Support key values from slf4j's fluent api
Jun 17, 2023
Thank you so much for the contribution and reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address issue #946.
The configurations are the same as the configurations for MDC.