Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support key values from slf4j's fluent api #954

Merged
merged 9 commits into from
Jun 17, 2023

Conversation

mmienko
Copy link

@mmienko mmienko commented May 15, 2023

This should address issue #946.
The configurations are the same as the configurations for MDC.

Copy link

@ferhtaydn ferhtaydn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@osigida can you merge if there's nothing left to address?

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #954 (07314e5) into main (af9f826) will decrease coverage by 0.40%.
The diff coverage is 54.38%.

@@             Coverage Diff              @@
##               main     #954      +/-   ##
============================================
- Coverage     72.05%   71.66%   -0.40%     
- Complexity     1353     1386      +33     
============================================
  Files           173      174       +1     
  Lines          4999     5113     +114     
  Branches        517      528      +11     
============================================
+ Hits           3602     3664      +62     
- Misses         1148     1189      +41     
- Partials        249      260      +11     
Impacted Files Coverage Δ
...va/net/logstash/logback/layout/LogstashLayout.java 0.00% <0.00%> (ø)
...n/java/net/logstash/logback/LogstashFormatter.java 53.00% <32.35%> (-4.23%) ⬇️
.../net/logstash/logback/encoder/LogstashEncoder.java 55.55% <53.33%> (-0.51%) ⬇️
...posite/loggingevent/KeyValuePairsJsonProvider.java 84.44% <84.44%> (ø)
...posite/loggingevent/LoggingEventJsonProviders.java 87.75% <100.00%> (+0.52%) ⬆️
...ogstash/logback/fieldnames/LogstashFieldNames.java 93.44% <100.00%> (+0.33%) ⬆️

@philsttr philsttr force-pushed the support-key-value-fluent-api branch from 5b51802 to 07314e5 Compare June 17, 2023 15:11
@philsttr philsttr changed the title Support key value fluent api Support key values from slf4j's fluent api Jun 17, 2023
@philsttr philsttr linked an issue Jun 17, 2023 that may be closed by this pull request
@philsttr philsttr merged commit 16c92fc into logfellow:main Jun 17, 2023
5 of 7 checks passed
@philsttr
Copy link
Collaborator

Thank you so much for the contribution and reviews!

@mmienko mmienko deleted the support-key-value-fluent-api branch June 17, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support keyValue pairs provided by slf4j 2.x fluent api
4 participants