Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new json provider to log root stack trace elements #395

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

worldtiki
Copy link
Contributor

@worldtiki worldtiki commented Mar 23, 2020

Hi 👋

I'm opening a draft for a new json provider.
It complements existing ones (ThrowableRootCauseClassNameJsonProvider, StackTraceJsonProvider, ...).
This provides details about the context of the exception, ie, it doesn't tell us that a NullPointerException occurred but rather that it occurred in MyClass.myMethod().

For example, MyClass.doSomething() calling MyOtherClass.doSomethingRisky() which throws an error will produce the following output.

{
   "root_stack_trace_element":{
      "class_name":"com.example.stacktraces.MyOtherClass",
      "method_name":"doSomethingRisky"
   }
}

@nikos912000
Copy link

Hi there. Is there any update on this?
This feature is pretty useful.

Copy link
Collaborator

@philsttr philsttr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for submitting the PR. I had one minor suggestion. After that is resolved I'll get it merged.

philsttr added a commit that referenced this pull request Apr 24, 2020
@philsttr philsttr merged commit a6ba836 into logfellow:master Apr 24, 2020
@philsttr philsttr added this to the 6.4 milestone Apr 24, 2020
@worldtiki worldtiki deleted the rootstacktraceelement branch April 24, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants