867 shortenedthrowableconverter truncate stacktrace based on regex pattern #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truncate the stacktrace after the first line matching the configured `truncatAfter` regex patterns is found.
Different JDK are producing stacktraces of different length -> make the test dynamic and do not assume the length of the stacktrace is fixed and known up-front.
Also, allows to use `-1` to disable features like `maxLength`, `maxNumberThrowable` and `shortenedClassNameLength` instead of having to use Integer.MAX which is hard to remember when writing the XML configuration.
Codecov Report
@@ Coverage Diff @@
## main #874 +/- ##
============================================
+ Coverage 71.24% 71.58% +0.34%
- Complexity 1284 1309 +25
============================================
Files 170 170
Lines 4869 4910 +41
Branches 508 514 +6
============================================
+ Hits 3469 3515 +46
+ Misses 1148 1147 -1
+ Partials 252 248 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
brenuart
deleted the
867-shortenedthrowableconverter-truncate-stacktrace-based-on-regex-pattern
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.