Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Clear timerFunctionForBufferedLogs if not needed #14
Conversation
This is an example of a fix for loggly/winston-loggly-bulk#12 with a small amount of code change. Note that these lines: ``` if (timerFunction === null) { timerFunction = setInterval(function () { sendBulkLogs(); },30000); } ``` produce the same bug when `isBulk` is `true`. See loggly/winston-loggly-bulk#13
|
I believe this was merged in #16. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is an example of a fix for loggly/winston-loggly-bulk#12 with a small amount of code change.
Please note that these lines in
common.js:node-loggly-bulk/lib/loggly/common.js
Lines 205 to 210 in ea91822
produce the same bug when
isBulkistrue.See loggly/winston-loggly-bulk#13. This PR does not address that just in case you would like to implement a better timing solution than using
setInterval. I would consider this fix temporary if merged.Thanks!