Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper.sh fix #22

Merged
merged 3 commits into from
Apr 13, 2018
Merged

Helper.sh fix #22

merged 3 commits into from
Apr 13, 2018

Conversation

sphen13
Copy link
Contributor

@sphen13 sphen13 commented Apr 13, 2018

With the help of @kginger, finally tracked down the bluesky 1.5 to 2.0 issue. Really came down to pkg receipts not being forgotten. It would then trigger bluesky to try to kill itself over an over even though bluesky 1.5 was already uninstalled. I also cleaned up the launchd unload commands as it would have only pulled one of the 2.

unload and remove both LaunchDaemons, remove pkg receipt.
LaunchDaemons were not getting unloaded completely, and the old pkg
receipts were not being forgotten. the phantom pkg receipt was causing
a loop that killed bluesky everytime helper.sh was being called.
Copy link
Contributor

@bestmacs bestmacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to flip 81 and 82. I don’t think the pkgutil command will run after the launchd is unloaded.
Other than that, awesome find on the 1.5 thing. I don’t recall adding a search for the pkg receipt in the if/then.

@sphen13
Copy link
Contributor Author

sphen13 commented Apr 13, 2018

yep makes sense :) done.

@bestmacs bestmacs merged commit f9c670e into logicnow:master Apr 13, 2018
@sphen13 sphen13 deleted the helper.sh-fix branch April 13, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants