Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goas: MMR for the zone transaction log #37

Merged
merged 3 commits into from
Aug 23, 2024
Merged

goas: MMR for the zone transaction log #37

merged 3 commits into from
Aug 23, 2024

Conversation

davidrusu
Copy link
Contributor

No description provided.

@davidrusu davidrusu requested a review from zeegomo August 22, 2024 23:15
zeegomo
zeegomo reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@zeegomo zeegomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have benchmarks for this somewhere?

goas/atomic_asset_transfer/common/src/mmr.rs Outdated Show resolved Hide resolved
@davidrusu
Copy link
Contributor Author

Do we have benchmarks for this somewhere?

What do you want to benchmark? we measure the proofs themselves.

@zeegomo
Copy link
Contributor

zeegomo commented Aug 23, 2024

I meant the difference in proof cycles before/after

@davidrusu
Copy link
Contributor Author

Sure thing! Here's the change in proving the Zone STF for different transactions:

zone op before total cycles after total cycles reduction
withdraw 3145728 2228224 29%
deposit 3145728 2162688 31%

@davidrusu davidrusu merged commit 75930a5 into goas/hash-based-balance-commitments Aug 23, 2024
@davidrusu davidrusu deleted the goas/mmr-in-zone-state branch August 23, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeegomo zeegomo zeegomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidrusu @zeegomo