Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizing elasticsearch environment and options #8

Merged
merged 3 commits into from Apr 16, 2014

Conversation

dpb587
Copy link
Contributor

@dpb587 dpb587 commented Apr 15, 2014

This would allow us to adjust elasticsearch runtime options (e.g. garbage collection flags) and environment variables (e.g. heap and paths).

@dpb587
Copy link
Contributor Author

dpb587 commented Apr 15, 2014

@mrdavidlaing, thoughts or review comments before merging?

@mrdavidlaing
Copy link
Member

@dpb587 I think there is real value in us shipping with the sane default settings which we have discovered the hard way.

Can you modify this so that:

  1. We use our default elasticsearch runtime options if none are specified in the deploy manifest
  2. The amount of ES heap is dynamic if not specified

@dpb587
Copy link
Contributor Author

dpb587 commented Apr 16, 2014

@mrdavidlaing, I've made the adjustments. I think in most cases we'll need to copy/override the JVM options with instance-specific ones, but now most of our defaults are there which should at least provide anyone with a head start to debugging and creating their own appropriate settings.

@mrdavidlaing
Copy link
Member

Perfect. Lets roll this into a release

@dpb587 dpb587 merged commit 4f3e0d0 into master Apr 16, 2014
@dpb587 dpb587 deleted the elasticsearch-vars-opts branch April 16, 2014 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants