Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Error in code block when edit #4565

Closed
ZackYJz opened this issue Mar 13, 2022 · 2 comments · Fixed by #4567
Closed

Data Error in code block when edit #4565

ZackYJz opened this issue Mar 13, 2022 · 2 comments · Fixed by #4567
Assignees
@andelf
Labels
editor:code Editor CodeMirror block :type/bug Something isn't working. Affects daily use.

Comments

@ZackYJz
Copy link

ZackYJz commented Mar 13, 2022 •
edited

What happened?

When I edit in code blcok, select some text,then click somewhere in codeblock.
Two kind of Data Error Happend：

  • auto copy some text append to bottom
  • or disapear symbol ``` in bottom

It happens from 0.5.8 to latest version and reproduce everyday !

Reproduce the Bug

  1. Copy Some code into code block
  2. select all text
  3. (try indent)
  4. click some where in code blcok

Expected Behavior

No response

Screenshots

2022-03-08_01-33-39 (1)

2022-03-13_15-39-33 (1)

Desktop Platform Information

MacOS 11.2.3 Version 0.6.3

Mobile Platform Information

No response

Additional Context

No response
@andelf andelf added editor:code Editor CodeMirror block :type/bug Something isn't working. Affects daily use. labels Mar 13, 2022
@andelf andelf self-assigned this Mar 13, 2022
@andelf
Copy link
Collaborator

andelf commented Mar 13, 2022

image

@andelf
Copy link
Collaborator

andelf commented Mar 13, 2022 •
edited

This might be a bug in TAB key handler.

The bug is caused by mousedown handler of CodeMirror editor.

andelf added a commit to andelf/logseq that referenced this issue Mar 14, 2022
@andelf
fix(code): avoid calling saving handler too often
297ed91 
Fix logseq#4565
andelf added a commit to andelf/logseq that referenced this issue Mar 14, 2022
@andelf
fix(code): avoid calling saving handler too often
5525305 
Fix logseq#4565
andelf added a commit to andelf/logseq that referenced this issue Mar 14, 2022
@andelf
fix(code): avoid calling saving handler too often
b99d74e 
Fix logseq#4565
@andelf andelf mentioned this issue Mar 14, 2022
Merged
tiensonqin pushed a commit that referenced this issue Mar 15, 2022
@andelf @tiensonqin
fix(code): avoid calling saving handler too often
888cab7 
Fix #4565
@xxchan xxchan mentioned this issue Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andelf andelf

Labels
editor:code Editor CodeMirror block :type/bug Something isn't working. Affects daily use.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(code): avoid calling saving handler too often andelf/logseq
2 participants
@andelf @ZackYJz