Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace hierarchy not showing up in parent page #6547

Closed
francescoragazzi opened this issue Sep 1, 2022 · 12 comments
Closed

Namespace hierarchy not showing up in parent page #6547

francescoragazzi opened this issue Sep 1, 2022 · 12 comments
Labels
filenames hierarchy Hierarchy/namespace pages :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section.

Comments

@francescoragazzi
Copy link

What happened?

When creating a simple page 1 / page 2 setup, the following weird behavior happens:

  • hierarchy shows in page 2, but not in page 1.
  • if I create page 1 before page 1 / page 2, there is a duplicate in the “all pages” view (even though it’s the same page when I click on it).
    See images of the problem here

Reproduce the Bug

  1. Create a page e.g. "poulet"
  2. Create a hierarchical child e.g. "poulet / bouillabaisse"
    => the page "tandoori" show hierarchy, but not "poulet".
    => in addition to that, in the "all pages" view, "poulet" is duplicate.

Expected Behavior

Expected behaviour is to see hierarchy in the parent page

Screenshots

Screenshot 2022-09-01 at 07 10 16

Screenshot 2022-09-01 at 07 10 24

Screenshot 2022-09-01 at 07 10 58

Desktop Platform Information

Macbook Pro M1 Max (16-inch, 2021)
Macos Monterey 12.5.1
Logseq v.0.8.3

Mobile Platform Information

No response

Additional Context

No response

@cnrpman cnrpman added the hierarchy Hierarchy/namespace pages label Sep 1, 2022
@cnrpman
Copy link
Collaborator

cnrpman commented Sep 1, 2022

I reproduce the case. It works correctly if you remove the spaces around /
I think having heading / trailing spaces around / is an invalid use case. We don't ensure the behavior.

@cnrpman cnrpman added filenames :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section. labels Sep 1, 2022
@francescoragazzi
Copy link
Author

Thank you so much! Problem solved.

@fixed
Copy link

fixed commented Sep 7, 2022

I am running into the same issue and I am a bit surprised as to why this breaks the hierarchy.

Having no spaces has a negative impact on legibility and can even be confusing. Consider this example:

"My project Foo/Exhibition Examples/Notes on Visuals/Legibility"

versus

"My project Foo / Exhibition Examples / Notes on Visuals / Legibility"

In the version without spaces, the boundaries between the path elements disappear visually. The whitespace is the most prominent separator and the slashes look like they are meant to convey alternatives or similarities. it looks like the page is about Examples and Notes, and Visuals and Legibility where it's actually meant as subtopics.

Even when looking at https://en.m.wikipedia.org/wiki/Slash_(punctuation) with respect to using the slash for conjuction and disjunction, to the quoted style guides recommend spaces before and after the symbol when separating groups that contain internal spacing.

On a technical level, there also doesn't seem to be a huge problem (granted I am just observing, not having any knowledge about the inner workings), as the splitting appears to work when looking upwards the hierarchy:
Screenshot_20220907-092751-275

@cnrpman
Copy link
Collaborator

cnrpman commented Sep 7, 2022

@fixed Heading / trailing spaces in the middle levels are not acceptable:
image
Every level in a hierarchy is a page. And page should not have any heading / trailing space.

@fixed
Copy link

fixed commented Sep 7, 2022

@cnrpman Could you elaborate on the reasoning behind that? I am not sure I follow what the problem is. Except for downwards hierarchy display, everything else appears to work as expected

@fixed
Copy link

fixed commented Sep 7, 2022

Alternatively, could we have a way to just display those page paths with added whitespacing around the slashes when used in blocks or in the page title? That would also solve the legibility problem while keeping the internal representation strict to not containing heading/trailing whitespace s on the branch elements

@cnrpman
Copy link
Collaborator

cnrpman commented Sep 7, 2022

@fixed Seems the heading / trailing spaces of pages are ignored in the actual click-in.
Now I change my idea. I can't say the spaces are wrong. But it's not considered in the original design.
I'm glad to review PR on making the display better.

@e0lithic
Copy link

e0lithic commented Dec 4, 2022

I am using Logseq v0.8.12 and this issue is happening even without spaces.

Let's say I create a page. Work/Startup. The hierarchy is only shown on the child page and the Work page doesn't show the hierarchy.

Another thing to note is this happens only for the top level parent. For example, if we created two pages. Work/Startup/Team1 and Work/Startup/Team2 then the Startup page would show the hierarchy, just the top level parent Work page will not show any hierarchy.

@atlterry
Copy link

atlterry commented Dec 4, 2022

I confirm what @e0lithic states - I noticed this morning that the top level does not show the child hierarchies; I'm sure this was working 2 days ago.

@florianjehn
Copy link

Also just noticed that this isn't working anymore.

@cnrpman
Copy link
Collaborator

cnrpman commented Dec 5, 2022

@florianjehn @atlterry @e0lithic
The issue you mentioned should have been fixed in the nightly (according to #7590)

Also, this issue is irrelevant to this #6547 ticket.

@sdvb
Copy link

sdvb commented Dec 8, 2022

Thanks for the update, I'll test the nightly since this wasn't working for me today as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filenames hierarchy Hierarchy/namespace pages :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section.
Projects
None yet
Development

No branches or pull requests

7 participants