Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash tags enclosed in double brackets is broken #8942

Closed
1 of 2 tasks
Zyrohex opened this issue Mar 29, 2023 · 4 comments · Fixed by #9030
Closed
1 of 2 tasks

Hash tags enclosed in double brackets is broken #8942

Zyrohex opened this issue Mar 29, 2023 · 4 comments · Fixed by #9030

Comments

@Zyrohex
Copy link

Zyrohex commented Mar 29, 2023

Search first

  • I searched and no similar issues were found

What Happened?

Adding a hashtag that's enclosed in double brackets fails in two conditions:

  1. If I have a page that already exists and I want to create a tag with double brackets, it defaults to naming the page with the double brackets
  2. If I have a page that contains a space (#[[Frantic Logseq]]) and I start the process of creating a hash tag, the lookup window will vanish when I add a space to the keyword search: (#[[Frantic ).

Reproduce the Bug

  1. Try creating a single word vs double word hash tag that's enclosed in double brackets

Expected Behavior

Logseq should be returning the correct format in the first scenario. In the second scenario it should continue performing a lookup after I insert a space character.

Screenshots

image

Logseq_GbivdKuwZX.mp4

Desktop or Mobile Platform Information

Windows 11
Logseq 0.9.0

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@Bad3r
Copy link
Collaborator

Bad3r commented Mar 29, 2023

Can be reproduced.
The issue is that the closing brackets aren't automatically added when writing #[[.

@lef-est
Copy link

lef-est commented Mar 29, 2023

could it be related to #8910 ?

@Zyrohex
Copy link
Author

Zyrohex commented Mar 29, 2023

Issue still exist in 0.9.1

@cnrpman cnrpman added parser Markdown/Org parser related editor editor:autocomplete :type/bug Something isn't working. Affects daily use. :type/regression and removed parser Markdown/Org parser related labels Apr 4, 2023
@cnrpman
Copy link
Collaborator

cnrpman commented Apr 4, 2023

It's really annoying and worth a higher priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants