Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hash tags enclosed in double brackets is broken #9030

Merged
merged 2 commits into from Apr 4, 2023
Merged

fix: hash tags enclosed in double brackets is broken #9030

merged 2 commits into from Apr 4, 2023

Conversation

tiensonqin
Copy link
Contributor

@tiensonqin tiensonqin commented Apr 4, 2023 •
edited

close #8942

  • e2e test

@tiensonqin tiensonqin marked this pull request as ready for review April 4, 2023 12:57
andelf
andelf approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QAed. LGTM.

Should a #title with spaces | be autocompleted with [[]] added?
Currently, #title and #[[title]] function in the same way.

logseq-cldwalker
logseq-cldwalker approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiensonqin Works great! 🐛 ⚡

e2e-tests/editor.spec.ts
@@ -48,6 +48,16 @@ test('hashtag search page auto-complete', async ({ page, block }) => {
await block.mustFill("done")
})

test('hashtag search #[[ page auto-complete', async ({ page, block }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@tiensonqin
Copy link
Contributor Author

Should a #title with spaces | be autocompleted with [[]] added?

@andelf yes, without [[]], #title with spaces will be parsed as a tag title with inline text with spaces.

@tiensonqin tiensonqin merged commit 045ae0e into master Apr 4, 2023
13 checks passed
@tiensonqin tiensonqin deleted the fix/tag-auto-complete branch April 4, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

@logseq-cldwalker logseq-cldwalker logseq-cldwalker approved these changes

@cnrpman cnrpman Awaiting requested review from cnrpman

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hash tags enclosed in double brackets is broken
3 participants
@tiensonqin @andelf @logseq-cldwalker