fix (Whiteboard): Paste shape #8636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprocketc
changed the title
sprocketc
changed the title
logseq-cldwalker
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
@sprocketc Copying shapes with command-shift-C works nicely on a mac! 👍 🚢
|
Could be good to mention this shortcut in the docs. I wouldn't know this would work otherwise. Fwiw I ignored this PR for awhile since it didn't have any reviewers requested and wasn't sure if you wanted it reviewed |
@logseq-cldwalker That's true, but we are going to change this behavior soon, because that's not what most users would expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows copy/pasting objects instead of references using
Ctrl+Shift+CandCtrl+V(see https://discord.com/channels/725182569297215569/1075712494150111324/1075712494150111324)I tried to add a test but couldn't make it work consistently, but I made some minor improvements to the test in the process.
There is a bigger issue here, which is the way copy/paste and dnd behaves. Copying the reference by default when we use
Ctrl+Cmight not be expected in whiteboards context, and should be re-evaluated in my opinion. Dragging and dropping links does not create an iFrame object. Also,usePaste.tsis almost 500 lines of code and is responsible for pasting and dropping. We need to refactor it soon and add more tests to eliminate similar issues.