Fix: Copy event and add/refactor tests #8777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprocketc
changed the title
sprocketc
changed the title
|
@sprocketc Should I QA anything besides copy on the search input? Unclear if whiteboard copy behavior is changing |
|
@logseq-cldwalker Yeah, copy/pasting shapes on whiteboards should now create a clone element instead of pasting a reference of the item. |
logseq-cldwalker
approved these changes
Mar 7, 2023
| } else { | ||
| await page.keyboard.press('Control+c') | ||
| } | ||
| await page.keyboard.press(modKey + '+c') |
There was a problem hiding this comment.
Nice refactor. Makes tests easier to read
| @@ -88,6 +88,63 @@ test('draw a rectangle', async ({ page }) => { | |||
| ).not.toHaveCount(0) | |||
| }) | |||
|
|
|||
| test('copy/paste url to create an iFrame shape', async ({ page }) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to change the copy/paste functionality as discussed on #8636, I realized that I can't handle this by modifying
usePaste.ts. The root cause seems to be the fact that(js/document.execCommand "copy")is firing twice onmod+c.:misc/copyalways executes a document copy and then:editor/copycallseditor-handler/shortcut-copy, which also executes(js/document.execCommand "copy")on certain conditions.As far as I understand,
mod+cwas introduced here 57d0436 to handle copying on the search panel on this PR #1191. If we remove this binding, usingmod+con the search input stops working. The changes on shortcut-copy were introduced on the same PR here e218ef7. I believe we can revert those changes, and just leteditor-handler/shortcut-copyoverwrite the clipboard when needed.mod+shift+cworked as expected in #8636, because(js/document.execCommand "copy")was called byshortcut-copy-textonly.Another cause of minor inconsistencies was calling
navigator.clipboard.writedirectly, instead of usingutil/copy-to-clipboard!that handles some scenarios gracefully.I added some copy/paste tests related to whiteboards. I also used
modKeywhen possible to simplify some of our existing tests. Worth noting that there is no clipboard isolation between tests in playwright yet, so we may need to keep an eye on those tests. Also note that we cannot copy whiteboard shapes on CI, becauseClipboardItemis not supported (see #5033).