You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes#9365 which was introduced in #9254. This brings back the previous behavior where the current block always has it's :block/path-refs transacted as noticed in #9254 (comment) . It seems this is needed. This PR fixes this by no longer having :block/path-refs as a retracted attribute. To QA, you can reproduce with the first minute of the video in #9365. You can also QA with:
Create a block foo #bar
Run show block data command on the block and note its :block/path-refs
Change block to fooz #bar
Rerun show block data command on the block and its :block/path-refs should not change
logseq-cldwalker
changed the title
Fix: Fix child blocks with disappearing path refs
Fix: Current block losing path-refs if refs don't change
May 13, 2023
@cnrpman More like a false fix. refs-changed? was a binding that was always evaluating to true. In #9254, we tried to fix it. In fixing it we introduced the current bug. This PR removes the binding since it seems the current block was dependent on it always being true
@tiensonqin I found the reason we end up needing to always transact :block/path-refs is because outliner-core/save-block! is always retracting the block's :block/path-refs attribute. I could make the fix there but I'm not confident that it wouldn't break something else
logseq-cldwalker
changed the title
Fix: Current block losing path-refs if refs don't change
Fix(editor): Fix blocks losing references and disappearing from references panel
May 22, 2023
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logseq-cldwalker
changed the title
This PR fixes #9365 which was introduced in #9254.
This brings back the previous behavior where the current block always has it's :block/path-refs transacted as noticed in #9254 (comment) . It seems this is needed.This PR fixes this by no longer having :block/path-refs as a retracted attribute. To QA, you can reproduce with the first minute of the video in #9365. You can also QA with:foo #barshow block datacommand on the block and note its :block/path-refsfooz #barshow block datacommand on the block and its :block/path-refs should not changeI'll see if I can do a test for this on Monday