Fix: Stale children block's path-refs when parent's refs change #9254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logseq-cldwalker
requested review from
andelf,
tiensonqin,
RCmerci,
cnrpman and
sprocketc
| (let [entity (db/entity [:block/uuid id])] | ||
| {:db/id (:db/id entity) | ||
| :block/path-refs (concat | ||
| (map :db/id (:block/path-refs entity)) |
There was a problem hiding this comment.
The bug was here as :block/path-refs had stale data
| @@ -41,14 +41,36 @@ | |||
| [(:db/id (:block/page block))] | |||
| (map :db/id (:block/refs block)) | |||
| parents-refs)) | |||
| ;; Usually has changed as new-refs has page id while old-refs doesn't | |||
| refs-changed? (not= old-refs new-refs) | |||
There was a problem hiding this comment.
I don't know if it's intentional but this was always changed when I inspected it because the old-refs didn't contain the page id
There was a problem hiding this comment.
It's a bug because :block/path-refs is included in the retracted-attributes, the block here is from the db-after which has no path-refs already. I made the change to get the old-refs from db-before.
tiensonqin
approved these changes
May 4, 2023
| @@ -0,0 +1,54 @@ | |||
| (ns frontend.modules.outliner.pipeline-test | |||
tiensonqin
force-pushed
the
fix/child-path-refs
branch
from
a63d4e4
to
7c4ed4d
Compare
logseq-cldwalker
added a commit
that referenced
this pull request
May 4, 2023
Also fix typo on 5677be9 /cc @tiensonqin
logseq-cldwalker
added a commit
that referenced
this pull request
May 13, 2023
Looks like refs-changed? always being true in #9254 was needed for downstream transactions. This brings back that behavior
logseq-cldwalker
added a commit
that referenced
this pull request
May 13, 2023
Looks like refs-changed? always being true in #9254 was needed for downstream transactions. This brings back that behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a longstanding bug where a child block's :block/path-refs holds on to old path-refs when a parent's refs change. Fixes #5759, #5992, #6990, #8430 and #4116. Since this bug allowed stale refs data, this lead to stale data in query results, linked references and maybe other places. To QA, add these blocks:
Observe that changing
#footo#barcleanly removes all the blocks from the query results. Another case to QA is toggle task states with children blocks as described in #5992