enhance: add tooltip hint for prefered-file-paste #9564
Conversation
Bad3r
force-pushed
the
enhance/settings-tooltips
branch
2 times, most recently
from
f17b14d
to
9fb39be
Compare
There was a problem hiding this comment.
@Bad3r Looking good. Just one request and this should be good to go
src/resources/dicts/de.edn
Outdated
| @@ -299,6 +299,7 @@ | |||
| :settings-page/custom-configuration "Individuelle Konfiguration" | |||
| :settings-page/custom-date-format "Bevorzugtes Datumsformat" | |||
| :settings-page/custom-date-format-warning "Neuindizierung erforderlich! Vorhandene Journal-Verweise würden nicht mehr funktionieren!" | |||
| :settings-page/preferred-pasting-file-hint "When enabled, pasting an image from the internet will download and insert the image. When disabled, it will paste the link to the image." | |||
There was a problem hiding this comment.
Worth removing all the non-english English entries like this. A language file should only contain entries for its language. Our translation system already handles defaulting to English when a key doesn't exist in another language
There was a problem hiding this comment.
@logseq-cldwalker sounds good will remove it. The reason I thought it should be included is to make it easier for translators to know what still needs to be translated.
There was a problem hiding this comment.
Gotcha. Most translators rely on this workflow which depends on entries being missing in a language
We should get rid of English entries in any non-English file as they are redundant and confusing translators. I'll try to knock this out next week but PR is welcome for this as well
Bad3r
force-pushed
the
enhance/settings-tooltips
branch
2 times, most recently
from
bdcd83b
to
3838659
Compare
Bad3r
force-pushed
the
enhance/settings-tooltips
branch
from
3838659
to
65cf1ee
Compare
This reverts commit 65cf1ee.
There was a problem hiding this comment.
@Bad3r Thanks for noticing this and making it more user friendly! 👍 🚢
* Remove deprecated :editor/command-trigger option This option has been deprecated for a couple months * enhance: auto pan * enhance: naming * fix: e2e tests * enhance: support whiteboard translations * fix: add whitespace * Update valid dicts lint and delete an unused key * enhance: add tooltip hint for prefered-file-paste (logseq#9564) * enhance: add tooltip hint for prefered-file-paste * Revert dict changes This reverts commit 65cf1ee. * chore: Update bug_report.yaml to reassure no question (logseq#9572) --------- Co-authored-by: Gabriel Horner <gabriel@logseq.com> Co-authored-by: Konstantinos Kaloutas <konstantinos@logseq.com> Co-authored-by: Junyi Du <junyidu.cn@gmail.com>
I don't know if the message is too long. I used an image as the most common example.