chore: remove false positive translations a.k.a. EN definitions in non EN dicts #9576
Conversation
Bad3r
changed the title
Bad3r
force-pushed
the
chore/update-non-en-dicts
branch
from
12a2126
to
f53abb8
Compare
|
Hey @logseq-cldwalker, this PR is a follow-up to the discussion #9564 (comment). Please TAL when you get a chance. |
Bad3r
force-pushed
the
chore/update-non-en-dicts
branch
2 times, most recently
from
3fc3214
to
0bdf3e1
Compare
Bad3r
changed the title
Bad3r
force-pushed
the
chore/update-non-en-dicts
branch
from
0bdf3e1
to
68a339c
Compare
There are still a few to remove. Remove lang:duplicates as it's now included in the linter
There was a problem hiding this comment.
@Bad3r Thanks for the help with removing false positives! 👍 🚢 With these removals I've been able to update the lang linter to disallow duplicates. I'll address the remaining few that were caught and address the comments
src/resources/dicts/es.edn
Outdated
| @@ -396,7 +393,6 @@ | |||
| :command.search/re-index "Reconstruir índice de búsqueda" | |||
| :command.editor/bold "Negrita" | |||
| :command.editor/italics "Cursiva" | |||
| :command.editor/insert-link "Enlace html" | |||
There was a problem hiding this comment.
We shouldn't be deleting these if they are translated. In en.edn this exists as :editor/insert-link. There is still some tech debt to address later around removing the weird mappings between shortcuts that don't have the :command prefix and their language keys which do have the :command prefix
There was a problem hiding this comment.
Forgot to mention that bb lang:validate-translations already catches unused keys automatically so this isn't something we have to be looking out for
src/resources/dicts/fr.edn
Outdated
| @@ -109,21 +107,17 @@ | |||
| :open-a-directory "Ouvrir un dossier local" | |||
| :open-new-window "Nouvelle fenêtre" | |||
| :page-search "Chercher dans la page en cours" | |||
| :plugins "Extensions" | |||
There was a problem hiding this comment.
French users purposely use extensions to mean plugins so I can undo these changes. Worth discussing this with french users in discord if you have a strong opinion about it as there are more places in this file to address
logseq-cldwalker
changed the title
src/resources/dicts/de.edn
Outdated
| @@ -20,11 +20,9 @@ | |||
| :export-page "Seite exportieren" | |||
| :export-public-pages "Öffentliche Seiten exportieren" | |||
| :export-roam-json "Als Roam JSON exportieren" | |||
| :graph "Graph" | |||
There was a problem hiding this comment.
Romance languages do use the same English word from time to time so I'm bringing some of these back that I've confirmed are correct. There's an allowed duplicates config in lang.clj for these exceptions
There was a problem hiding this comment.
sounds good. The issue I ran into with this is where to set the line? For example many Germanic languages use 'code' and 'plugin' since there is no equivalent for it in many languages.
There was a problem hiding this comment.
| @@ -490,7 +470,6 @@ | |||
| :command.graph/re-index "Aktuellen Graph neu indizieren" | |||
| :command.graph/remove "Einen Graph entfernen" | |||
| :command.graph/save "Aktuellen Graph auf Festplatte speichern" | |||
| :command.misc/copy "mod+c" | |||
There was a problem hiding this comment.
Agree with removing "mod+c" everywhere as this is the only key that used the keybinding as a description, which isn't helpful
Also undo removals in this PR of translations that were being used. Also changed :misc/copy translation since it didn't have a meaningful description
logseq-cldwalker
force-pushed
the
chore/update-non-en-dicts
branch
from
ff5c7b3
to
1765ecf
Compare
TODO:
Back Links-->BacklinksNotes:
:command.editor/insert-link:command.misc/copy