Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Aliased pages not included in published subgraph #9600

Merged
merged 1 commit into from Jun 7, 2023

Conversation

logseq-cldwalker
Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker commented Jun 6, 2023

This PR fixes #4143. To reproduce:

  1. create a public page with an alias
  2. create another public page that has two links, one to the page and one to the page alias
  3. Be sure logseq/config.edn has :publishing/all-pages-public? false
  4. Run bb dev:publishing ... to build the publishing app per https://github.com/logseq/logseq/blob/master/docs/dev-practices.md#babashka-tasks
  5. The aliased link should correctly redirect to the original page

For these first two steps, you can QA the exact pages I used by using the logseq-export and logseq-import CLIs and the following export.edn content:

[#:file{:content
        "public:: true\n\n- https://github.com/logseq/logseq/issues/5280\n\t- [[page 5280]]\n\t- [[page 5280-alias]]",
        :path "journals/2023_06_06.md"}
 #:file{:content "alias:: page 5280-alias\npublic:: true\n\n- content",
        :path "pages/page 5280.md"}]

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiensonqin tiensonqin force-pushed the fix/aliases-on-published-subgraphs branch from bd45f30 to 055dc24 Compare June 7, 2023 05:47
@tiensonqin tiensonqin merged commit 480429a into master Jun 7, 2023
8 checks passed
@tiensonqin tiensonqin deleted the fix/aliases-on-published-subgraphs branch June 7, 2023 05:47
@logseq-cldwalker logseq-cldwalker changed the title Fix: Alias pages not included in published subgraph Fix: Aliased pages not included in published subgraph Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page alias not working in published subgraph
4 participants