Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page alias not working in published subgraph #4143

Closed
MrVPlusOne opened this issue Feb 7, 2022 · 5 comments · Fixed by #9600
Closed

Page alias not working in published subgraph #4143

MrVPlusOne opened this issue Feb 7, 2022 · 5 comments · Fixed by #9600

Comments

@MrVPlusOne
Copy link

What happened?

Hi, I noticed that alias references seem broken in the exported graph (when viewing inside a browser), as shown in the following two examples. They just resolve to an empty page.

Within the original page:
image

Outside references:
image

Reproduce the Bug

  1. Publish any page with an alias:: property.
  2. Export the graph into HTML and open it using a browser.
  3. Navigate to that page.
  4. Hover preview or click on the alias reference, like shown below
    image

Expected Behavior

The alias should work like in the desktop app.

Screenshots

No response

Desktop Platform Information

  • OS: macOS 12.1
  • Browser Chrome 97.0.4692.99 (Official Build)
  • Version: Version 0.5.9 (0.5.9), nightly build.

Mobile Platform Information

No response

Additional Context

No response

@logseq-cldwalker
Copy link
Collaborator

logseq-cldwalker commented Oct 14, 2022

Hi. Could you try 0.8.8? This is working for me on the latest version

@logseq-cldwalker logseq-cldwalker added need-to-reproduce More clues are required to reproduce the issue. awaiting-response Issue will be closed if a reply is not received and removed props Properties labels Oct 14, 2022
@MrVPlusOne
Copy link
Author

Hi. Could you try 0.8.8? This is working for me on the latest version?

Weirdly, it's still not working on my computer as shown below:
image

I'm using 0.8.8 nightly build on MacOS, and I have tested it in both Chrome and Safari with the same result.

@logseq-cldwalker
Copy link
Collaborator

@MrVPlusOne Unfortunately I can't reproduce this. Hovering over the alias of a page isn't blank for me
Screen Shot 2022-10-21 at 3 47 55 PM
Can you provide the example page that has the alias and the example blocks that have the referenced alias page?

@Bad3r Bad3r moved this to 🗄 Backlog in :Logseq/Issue-Tracker Jan 1, 2023
@tzcl
Copy link

tzcl commented Feb 11, 2023

I'm also encountering this issue. To add more info, if all pages are marked public for export then the alias works fine. The problem occurs when not all pages are exported.

For an example, see https://notes.tzcl.me/#/page/andy%20matuschak vs https://notes.tzcl.me/#/page/andy

@tomtung
Copy link

tomtung commented Mar 17, 2023

It appears that the published public subgraph isn't working as expected in various contexts, including page links, tag links, and aliases, as we can see here.

For instance, suppose a public page [[A]] is linked to (or tagged with) a non-public page [[B]] (or #B). In that case, when we click through from [[A]] to [[B]] in the exported graph, [[B]] is rendered as a completely empty and dysfunctional page instead of showing [[A]] as one of its linked references.

This makes publishing a fully "functional" public subgraph very tedious, as we need to ensure that we materialize a page file for everything that's linked, tagged, or used as an alias in a public page, then explicitly mark every such page file as public.

A more robust general solution might be to treat anything non-public referenced by a public page, be it aliases, tags, or other pages, as empty pages, and then index and render them accordingly. However, I'm unsure of how much work this solution would require.

@cnrpman cnrpman removed awaiting-response Issue will be closed if a reply is not received need-to-reproduce More clues are required to reproduce the issue. labels Jun 4, 2023
@logseq-cldwalker logseq-cldwalker changed the title Page alias not working in published graph Page alias not working in published subgraph Jun 6, 2023
@logseq-cldwalker logseq-cldwalker self-assigned this Jun 6, 2023
tiensonqin pushed a commit that referenced this issue Jun 7, 2023
tiensonqin pushed a commit that referenced this issue Jun 7, 2023
@github-project-automation github-project-automation bot moved this from 🗄 Backlog to ✔ DONE in :Logseq/Issue-Tracker Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants