Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Remote IP address in the Event medata #218

Closed
wants to merge 1 commit into from

Conversation

jakelandis
Copy link
Contributor

Adds ip_address to the @metadata field. The ip is the remote host address as seen by Netty.

Fixes #180

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@jakelandis
Copy link
Contributor Author

Close and Reopen to kick off Travis again.

(unrelated/random) Test failure issue : #219

@jakelandis jakelandis closed this Jun 8, 2017
@jakelandis jakelandis reopened this Jun 8, 2017
@jakelandis
Copy link
Contributor Author

Travis failed again.... different reason.

See: #219

Close/Reopen again.

@jakelandis jakelandis closed this Jun 8, 2017
@jakelandis jakelandis reopened this Jun 8, 2017
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM lets rebase and merge, wohoo much requested feature :)

@jakelandis
Copy link
Contributor Author

Grr... can't get a clean build. Failures are un-related to the code, but would prefer to wait for green before merging.

See #222

Adds ip_address to the @metadata field. The ip is the remote host address as seen by Netty.

Fixes logstash-plugins#180
@elasticsearch-bot
Copy link

Jake Landis merged this into the following branches!

Branch Commits
master cc0976b

@acchen97
Copy link

@jakelandis thanks for taking care of this one. Should we update the plugin documentation to show that this metadata is now available? I suspect many users will find this feature useful.

@jakelandis
Copy link
Contributor Author

@acchen97 - thanks for the reminder. I have logged #249 to address the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants