Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guidance regarding the private key format and encoding #445

Merged
merged 6 commits into from
Jan 28, 2022
Merged

Update guidance regarding the private key format and encoding #445

merged 6 commits into from
Jan 28, 2022

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jan 12, 2022

  1. clarify that the pkcs8 key should be PEM encoded
  2. update the openssl pkcs8 command link that was broken
  3. provide an example of how to convert from PKCS1 to PKCS8

@jsvd jsvd added the docs label Jan 12, 2022
@jsvd jsvd requested a review from karenzone January 12, 2022 10:23
karenzone
karenzone reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this helpful information.

I left some suggestions on formatting/wording tweaks inline for your consideration, and will leave those entirely up to your discretion. Happy to test locally again to validate formatting for whatever you decide.

docs/index.asciidoc Outdated Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
jsvd and others added 2 commits January 18, 2022 10:16
@jsvd @karenzone
Update docs/index.asciidoc
a15bd26 
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
@jsvd @karenzone
Update docs/index.asciidoc
c2aaf28 
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
@jsvd jsvd requested a review from karenzone January 18, 2022 10:17
@karenzone
Copy link
Contributor

karenzone commented Jan 18, 2022 •
edited
Loading

Nice! Looks like this now:

Screen Shot 2022-01-18 at 6 34 10 PM

karenzone
karenzone approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements to both the content and formatting. Thank you!

@jsvd
Copy link
Member Author

jsvd commented Jan 28, 2022

bump patch

@jsvd jsvd merged commit 01648ba into main Jan 28, 2022
@jsvd jsvd deleted the jsvd-patch-2 branch January 28, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

Assignees

@jsvd jsvd

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsvd @karenzone @roaksoax