Do not use the identity map unless we specify the multiline codec. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some case when multiples FB clients are connected to the server and and watching a lot of files we can hit the limit or the 20K identity stream. This PR doesnt solve the 20K problems, but changes when the identity map is used, we will only use it if the multiline codec is defined in the configuration file. When its not the case the codec will be reuse accross connection thread. We can do that since our codec are stateless.
|
@ESamir @guyboertje The fix we talk earlier this morning. |
|
LGTM - (did not test locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case when multiples FB clients are connected to the server and
and watching a lot of files we can hit the limit or the 20K identity
stream. This PR doesnt solve the 20K problems, but changes when the
identity map is used, we will only use it if the multiline codec is
defined in the configuration file. When its not the case the codec will
be reuse accross connection thread. We can do that since our codec are
stateless.
Help with #66 when not using the multiline codec.