Improve the documentation of sincedb and file rotations #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the exact semantics of the sincedb files isn't documented anywhere and lack of understanding of this is very common among users.
The term "glob" is a Unix colloquialism that we can't expect all users to be familiar with, especially not those with a Windows background.
|
+1 - totally wrecked my indexing by changing the path pattern without knowing it would change the sincedb 😭 and I read the docs. |
|
Merged sucessfully into master! |
jordansissel
pushed a commit
that referenced
this pull request
Aug 21, 2015
The term "glob" is a Unix colloquialism that we can't expect all users to be familiar with, especially not those with a Windows background. Fixes #61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confusion over sincedb and how it works seems to be one of the major hurdles when people try out Logstash. This should improve the situation and at least give people who are willing to read documentation rather than read code a chance to understand.
I'm not 100% sure about the file rotation semantics. Since there's no documentation of that anywhere this is what I've gathered from reading the filewatch library code and experimenting.