Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue_owner_aws_account_id #60

Merged
merged 4 commits into from
Jan 29, 2022
Merged

Conversation

theredcat
Copy link
Contributor

Hello !

This PR is basically a copy of #38 by @majjacz with @ph remarks implemented.

It allow to use a queue shared between two AWS accounts that have been configured with SQS embed access policies instead of an IAM role using the queue_owner_aws_account_id option

@theredcat
Copy link
Contributor Author

theredcat commented Jan 19, 2022

@jsvd I tagged PH on this issue but it seem that you are the new maintainer of this plugin. Could you take a look at this ?

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, I've left a few comments, similar to those in #38.
If you can, please include a minor version bump (major.minor.patch) and a new entry in the changelog.md so we can publish it after the changes.

lib/logstash/inputs/sqs.rb Outdated Show resolved Hide resolved
docs/index.asciidoc Show resolved Hide resolved
spec/inputs/sqs_spec.rb Outdated Show resolved Hide resolved
@theredcat
Copy link
Contributor Author

Thank you for the contribution, I've left a few comments, similar to those in #38. If you can, please include a minor version bump (major.minor.patch) and a new entry in the changelog.md so we can publish it after the changes.

@jsvd That's done. I've bumped from 3.1.3 to 3.2.0 since this is a new feature. I hope that was the right thing to do ?

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsvd jsvd merged commit 23508eb into logstash-plugins:main Jan 29, 2022
@jsvd
Copy link
Member

jsvd commented Jan 29, 2022

@theredcat thank you for the contribution and iterations, this change has been published in 3.2.0 https://rubygems.org/gems/logstash-input-sqs/versions/3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants