-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add queue_owner_aws_account_id #60
Conversation
b0a01da
to
32a184f
Compare
@jsvd I tagged PH on this issue but it seem that you are the new maintainer of this plugin. Could you take a look at this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, I've left a few comments, similar to those in #38.
If you can, please include a minor version bump (major.minor.patch) and a new entry in the changelog.md so we can publish it after the changes.
@jsvd That's done. I've bumped from 3.1.3 to 3.2.0 since this is a new feature. I hope that was the right thing to do ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@theredcat thank you for the contribution and iterations, this change has been published in 3.2.0 https://rubygems.org/gems/logstash-input-sqs/versions/3.2.0 |
Hello !
This PR is basically a copy of #38 by @majjacz with @ph remarks implemented.
It allow to use a queue shared between two AWS accounts that have been configured with SQS embed access policies instead of an IAM role using the
queue_owner_aws_account_id
option