Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Better wording for 'tcp_keep_alive' option #169

Merged

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Mar 18, 2021

Describes better what's the meaning of the tcp_keep_Alive setting

@andsel andsel added the docs label Mar 18, 2021
@andsel andsel requested a review from karenzone March 18, 2021 15:02
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this clarification, @andsel. I made some minor suggestions for your consideration.

docs/index.asciidoc Show resolved Hide resolved
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this clarification

@andsel andsel force-pushed the fix/doc_keep_alive_better_wording branch from a3b7e50 to f717a8f Compare March 23, 2021 17:19
@andsel andsel merged commit 092daf6 into logstash-plugins:master Mar 23, 2021
@karenzone
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants