Update check_connection method to use empty document list index request #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
changed the title
andsel
force-pushed
the
fix/workplace_check_connection_to_use_empty_index_method
branch
2 times, most recently
from
f9bb9b9
to
ac8355c
Compare
andsel
force-pushed
the
fix/workplace_check_connection_to_use_empty_index_method
branch
from
ac8355c
to
615b4d2
Compare
Instead of relying on the private ws/org/sources/form_create endpoint to create a source, this commit switches to the combination of the public ones: - api/ws/v1/whoami to retrieve the access_token related to the basic authentication - api/ws/v1/sources to create a custom source to be usedby the integration test
andsel
commented
Jan 28, 2022
| @@ -8,6 +8,7 @@ COPY --chown=logstash:logstash *.gemspec VERSION* version* /usr/share/plugins/pl | |||
| RUN cp /usr/share/logstash/logstash-core/versions-gem-copy.yml /usr/share/logstash/versions.yml | |||
| ENV PATH="${PATH}:/usr/share/logstash/vendor/jruby/bin:/usr/share/logstash/jdk/bin" | |||
| ENV LOGSTASH_SOURCE="1" | |||
| ARG ELASTIC_STACK_VERSION | |||
There was a problem hiding this comment.
Note for reviewer:
without this the ENV['ELASTIC_STACK_VERSION'] doesn't contain value
kaisecheng
approved these changes
Jan 28, 2022
| "Accept" => "application/json", | ||
| "Authorization" => "Bearer #{access_token}"} | ||
| ) | ||
| puts "DBG>> source_id response body: #{response.body}" |
There was a problem hiding this comment.
do you really want to print value here?
There was a problem hiding this comment.
No, my bad I didn't remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Change implementation of connectivity check method to be compatible with version
8.0of Workplace.What does this PR do?
Change implementation of
check_connection!method, replacing the call tolist_all_permissionswhich doesn't have anymore a peer endpoint in8.0to an empty document listindex_documents.Fixes also the integration tests for Workplace Search version 8, switching API to retrieve the
access_tokenWhy is it important/What is the impact to the user?
Fixes a compatibility problem with Workplace Search
8.0Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues