Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: avoid insist usage in spec #18

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

kares
Copy link
Contributor

@kares kares commented Mar 12, 2020

... for devutils 2.0 compatibility

also scoped java_import to reduce potential name clashes

@kares
Copy link
Contributor Author

kares commented Mar 12, 2020

merged: #3 ... so that the refactoring fits for the 10.0.1 minor release

@elasticsearch-bot elasticsearch-bot self-assigned this Mar 12, 2020
@robbavey
Copy link
Contributor

@kares There is a test failure on master that looks like it might be related.

@kares
Copy link
Contributor Author

kares commented Mar 12, 2020

Thanks Rob, those NoSuchMethodError are due the recent JRuby 9.2.11 upgrade.
Dealing with those is planned (by doing a mass plugin upgrade): elastic/logstash#11662

Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kares kares merged commit 931f8c5 into logstash-plugins:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants