Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped version to 2.4.1 and fixed backwards incompatible behaviour #20

Closed

Conversation

mburger
Copy link
Contributor

@mburger mburger commented May 3, 2016

as was brought to my attention today, it seems my last pull request broke the default behaviour when specifying ssl => true, as we now pass a string and march-hare does not validate what you pass to it and just assumes its the name of a valid securiry context, i'm truly sorry for the trouble this might have caused already but as i didnt use a boolean value in the config myself and the tests where green i assumed the change will be ok, this pull request fixes it


Error Message:
{:timestamp=>"2016-05-03T07:42:21.273000+0000", :message=>"true SSLContext not available", :class=>"Java::JavaSecurity::NoSuchAlgorithmException", :location=>"sun.security.jca.GetInstance.getInstance(sun/security/jca/GetInstance.java:159)", :level=>:warn, :file=>"logstash/inputs/rabbitmq.rb", :line=>"180", :method=>"register"}

@andrewvc
Copy link
Contributor

Thanks for the PR @mburger . I think my PR #22 will do a more complete job. I'm going to close this one given that I plan on merging that soon.

WDYT?

@mburger
Copy link
Contributor Author

mburger commented May 12, 2016

@andrewvc sounds good :)

@mburger mburger closed this May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants