Feat: Added support for cloud_id and cloud_auth #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
changed the title
robbavey
requested changes
Dec 16, 2019
| begin # might not be available on older LS | ||
| require 'logstash/util/cloud_setting_auth' | ||
| rescue LoadError | ||
| raise LogStash::ConfigurationError, 'The cloud.auth setting is not supported by LogStash, please set user/password instead.' |
There was a problem hiding this comment.
Nits: cloud.id should read cloud_id to reflect configuration property name
Capitalization of "LogStash" should read Logstash
Maybe state that the setting is not supported by this version of Logstash, as later versions do support it.
robbavey
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
LGTM - @karenzone can you take a look at the docs for this plugin (might we also want to add a reference to this in the cloud id usage doc in the main Logstash docs?)
|
circling back here, as this was promised to eventually land in next LS release ... |
This was referenced Jan 7, 2020
Feat: support cloud_id / cloud_auth configuration
logstash-plugins/logstash-filter-elasticsearch#122
Merged
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be fairly straight-forward:
resolves: #893
TODO documentation for new options