Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(phrases): add translation ko_KR #1677

Merged
merged 2 commits into from
Jul 30, 2022
Merged

chore(phrases): add translation ko_KR #1677

merged 2 commits into from
Jul 30, 2022

Conversation

pemassi
Copy link
Contributor

@pemassi pemassi commented Jul 26, 2022

Summary

I have added translation for Korean.

Testing

I have problem with building packages in MacBook M1 (arch64), so I have only checked Lint.

@gao-sun
Copy link
Member

gao-sun commented Jul 26, 2022

thanks @pemassi! this is amazing. would you like to remove package-lock.json? we also have contributing guideline available.

@simeng-li
Copy link
Contributor

@pemassi what exact errors did you receive? We are actually using M1 for development as well. Let us know if you run into any issues by following our contributing guide.

@pemassi
Copy link
Contributor Author

pemassi commented Jul 26, 2022 •
edited
Loading

@gao-sun I have deleted, sorry about that.

@simeng-li I have succeed to fix the build bug. The reason was that I am using xcode-select library. I can be fixed with below command.

PATH="$(xcode-select -p)/Toolchains/XcodeDefault.xctoolchain/usr/bin:$PATH"
export SDKROOT=$(xcrun --sdk macosx --show-sdk-path)

@pemassi
Copy link
Contributor Author

pemassi commented Jul 26, 2022

Seems like, I need to add translation into connector's metadata. Change to draft.

@pemassi pemassi marked this pull request as draft July 26, 2022 07:42
@gao-sun
Copy link
Member

gao-sun commented Jul 26, 2022

@pemassi no worries, just let us know if you meet any questions. you can also join our Discord for a live chat. look forward to your updates!

@pemassi pemassi changed the title chore(phrases-ui): add translation ko_KR chore(connector, phrases, phrases-ui): add translation ko_KR Jul 26, 2022
@charIeszhao
Copy link
Member

Hey @pemassi , thanks for your awesome work!

I'm writing to let you know that we just made some adjustments to the i18n architecture, because we can see the difficulties for a contributor to add a new language support right now. With the new update, the mainflow UI (sign-in forms) will have its own i18n language options, which can be different from the ones used in admin console.

This enables contributors to easily provide a language phrase ONLY for the sign-in mainflows, without worrying about the connectors and the admin console, as they are only admin features.

You can now rebase your branch from the master branch and slightly update your work. Let me know if you have any questions, thanks!

@pemassi pemassi marked this pull request as ready for review July 29, 2022 11:01
@pemassi
Copy link
Contributor Author

pemassi commented Jul 29, 2022

I have translated all wordings so far. However, after I merged the latest master branch into mine, I am getting an error on testing. Looks like there is a problem with @logto/connector-azuread.

@pemassi
Copy link
Contributor Author

pemassi commented Jul 29, 2022

@demonzoo @gao-sun I am not able to see Korean in the language selection in the setting. Is there anything need to do to see Korean?

image

@pemassi pemassi mentioned this pull request Jul 29, 2022
Closed
@pemassi pemassi changed the title chore(connector, phrases, phrases-ui): add translation ko_KR chore(connector, phrases, console): add translation ko_KR Jul 29, 2022
@charIeszhao
Copy link
Member

@demonzoo @gao-sun I am not able to see Korean in the language selection in the setting. Is there anything need to do to see Korean?

image

You need to add Korean in @logto/phrase-ui as well, as I've mentioned in an earlier comment, I have separated the mainflow language options from admin console. So you need to add Korean option in phrase-ui package as well

@gao-sun
Copy link
Member

gao-sun commented Jul 29, 2022 •
edited
Loading

@pemassi this is incredible. thank you!

@demonzoo would like to help the op to update?

@charIeszhao
Copy link
Member

Hi @pemassi , if you have further questions, you can join our discord channel to chat with us. I'll help you out with this PR.

@pemassi
Copy link
Contributor Author

pemassi commented Jul 30, 2022

@demonzoo Thanks for helping. I have added Korean in phrases-ui also.

image

I guess this PR is ready to set. Please let me know if there can be improved.

@charIeszhao
Copy link
Member

Nice! I'll review your PR tonight. Thanks again for your great work 👍

@gao-sun gao-sun closed this Jul 30, 2022
@gao-sun
Copy link
Member

gao-sun commented Jul 30, 2022

@pemassi sorry i closed this by accident. your work has been saved. i'll fix this

@gao-sun gao-sun reopened this Jul 30, 2022
@pemassi @gao-sun
chore(phrases): add translation ko_KR
9442d2d 
chore(connector): add translation ko_KR

chore(phrases): add translation ko_KR

test: add mock translation for ko_KR

Update packages/phrases-ui/src/locales/ko-kr.ts

Co-authored-by: Charles Zhao <charleszhao@silverhand.io>

Update packages/phrases-ui/src/locales/ko-kr.ts

Co-authored-by: Charles Zhao <charleszhao@silverhand.io>

chore(phrases): update translation ko_KR

chore(phrases): edit translation ko_KR, make more friendly

chore(phrases): fix typo

chore(phrases): make translation smooth ko_KR

chore(phrases): edit translation ko_KR

chore(console): add translation ko_KR

chore(phrases): add korean language for login ui
gao-sun
gao-sun approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@gao-sun gao-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@gao-sun gao-sun changed the title chore(connector, phrases, console): add translation ko_KR chore(phrases): add translation ko_KR Jul 30, 2022
@gao-sun gao-sun enabled auto-merge (squash) July 30, 2022 14:35
@gao-sun gao-sun merged commit d1900e1 into logto-io:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charIeszhao charIeszhao charIeszhao left review comments

@gao-sun gao-sun gao-sun approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pemassi @gao-sun @simeng-li @charIeszhao